Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get user when using dev token and update README for non-employees #3026

Closed
wants to merge 3 commits into from

Conversation

jeffl8n
Copy link

@jeffl8n jeffl8n commented Jul 13, 2024

Fixed an issue with getting the user token when using the VITE_KC_DEV_TOKEN environment variable and not having access to the dev API.

Also updated the README to suggest using VITE_KC_DEV_TOKEN over running the web console command to set the token.

Related to #2242

Copy link

qa-wolf bot commented Jul 13, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Jul 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Aug 21, 2024 4:05am

@jeffl8n
Copy link
Author

jeffl8n commented Aug 22, 2024

Looks like the code fix part of this PR was already addressed with #3315

https://github.com/KittyCAD/modeling-app/pull/3315/files#diff-5ecc9b92b2683f46d732954f21d2ff91498a8ad4e657013d8a131f1a1af78fbfR134

This PR can be closed unless you want the README update still since it is the only change now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants