default to production when no NODE_ENV #3614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lf94
approved these changes
Aug 22, 2024
| if (!process.env.NODE_ENV) | ||
| console.warn( | ||
| '*FOX SCREAM* process.env.NODE_ENV is not explicitly set!, defaulting to production' | ||
| ) |
There was a problem hiding this comment.
Ah yes we need this because the built package won't work I actually told jess about it a few days ago, nice catch!
I'm a little on the fence exposing this error to users but at the same time I can imagine anyone missing this argument and wondering what's going on. So I think it's good as-is.
There was a problem hiding this comment.
yeah mostly likely their app launcher is going to eat all these logs anyways
|
failures were unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3576
Looks like something @lf94 added so I'll put him on review in case there's something I'm missing here.