Add asn1 signature encoding to signer and verifier #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, we're using a library (for another language), which doesn't support concatenating
r
ands
for the signature, so we needed a way to use a common encoding. Since the "original" encoding when used in iOS (or macOS) is ASN1, this data is already available inside theECSignature
.This change isn't breaking, since without changing anything, the old encoding is used.
I know, this isn't quite correct for the JWS standard, but maybe there are other people running into this problem. What do you think about this option?