Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asn1 signature encoding to signer and verifier #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

code28
Copy link

@code28 code28 commented Nov 19, 2019

Unfortunately, we're using a library (for another language), which doesn't support concatenating r and s for the signature, so we needed a way to use a common encoding. Since the "original" encoding when used in iOS (or macOS) is ASN1, this data is already available inside the ECSignature.
This change isn't breaking, since without changing anything, the old encoding is used.

I know, this isn't quite correct for the JWS standard, but maybe there are other people running into this problem. What do you think about this option?

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants