Add HeaderProtocol to support flexible header definitions #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can see an example use of the flexible header here: https://github.com/finlabsuk/open-banking-connector/blob/master/Sources/OpenBankingConnector/jws.swift. (I've temporarily made the OBC project dependent on the fork.) |
djones6
reviewed
Jan 6, 2020
| @@ -46,11 +46,11 @@ public struct JWT<T: Claims>: Codable { | |||
| /// - Parameter header: A JSON Web Token header object. | |||
| /// - Parameter claims: A JSON Web Token claims object. | |||
| /// - Returns: A new instance of `JWT`. | |||
| public init(header: Header = Header(), claims: T) { | |||
| public init(header: H, claims: T) { | |||
There was a problem hiding this comment.
This would be a breaking change. Is it possible to retain the default value for header so that it is non-breaking? (ie. the tests should not have to change, unless you are adding one to test the new facility).
|
Mark Murphy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Michaellyn55
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds HeaderProtocol to allow external Header definitions to be used as well as encode() overriding. This change aligns header structure to that used for claims.