Bbox #699
Bbox #699
Conversation
src/Context/LayersMachineContext.js
Outdated
| @@ -7,6 +7,9 @@ class LayersMachineContext { | |||
|
|
|||
| // A { name, data } object, queued for creation of the data's actor | |||
| lastAddedData = null | |||
|
|
|||
| // Draw bounding boxes around image and label (if loaded) | |||
| labelBBoxEnabled = false | |||
There was a problem hiding this comment.
Should this state be associated with the actual image, not in this image aggregating parent?
There was a problem hiding this comment.
This is now a map of each layer and its bounding box visibility status. That makes sense though. Maybe each layer's status should live with its LayerActorContext instead of at the top level here?
There was a problem hiding this comment.
Yeah. Or the ImageActorContext, i'm not sure.
There was a problem hiding this comment.
I've moved it to the LayerActorContext for now as each layer can simply have a boolean bbox key associated with it. Moving it to the ImageActorContext would be just as simple, we'd just need an imageBBox and labelBBox (or something along those lines) associated with each image actor.
There was a problem hiding this comment.
Most excellent.
In the future, it will also be useful to show the bounding box for point sets, etc.
| @@ -148,6 +148,11 @@ function createImagesRenderingMachine(options, context) { | |||
| to: (c, e) => `imageRenderingActor-${e.data}`, | |||
| }), | |||
| }, | |||
| TOGGLE_LABEL_BBOX: { | |||
| actions: send((_, e) => e, { | |||
| to: c => `imageRenderingActor-${c.images.selectedName}`, | |||
There was a problem hiding this comment.
Should this event include the name of the image in the payload like the the other events? So the UI layer pulls selectedName and puts it in data: { name: selectedName }. Then can toss the event name on the makeTransitions forwardToNamedActor block below. Things are inconsistent, but better every day.
| @@ -702,6 +704,16 @@ function ItkVtkViewProxy(publicAPI, model) { | |||
| model.axesCircleRadius = 4 | |||
| model.axesTextOffset = 14 | |||
|
|
|||
| model.enableLabelBBox = false | |||
There was a problem hiding this comment.
Is it possible to avoid duplication of state and pull this boolean from the context?
There was a problem hiding this comment.
I am using the model's enabled flag to guard against unnecessary render calls by comparing it to the context state.
There was a problem hiding this comment.
Could compare the visibility boolean from the actor. Or just call actor.setVisiblity and if vtk.js is working right, it will do the guard check and won't render if nothing changed.
| const actorContext = context.images.actorContext.get(imageName) | ||
| if (actorContext?.labelImageName === multiscaleLabelImage.name) { | ||
| actorContext.labelImage = multiscaleLabelImage | ||
| service.send({ type: 'LABEL_IMAGE_ASSIGNED', data: imageName }) |
bnmajor
force-pushed
the
bbox
branch
2 times, most recently
from
9fd6526
to
2196565
Compare
|
Awesome!! |
Provide a toggle for drawing the bounds of the label image. Useful for understanding where a label image may be in space, especially if direction or origin are incorrect.
…reset When a label image was set the old label image was replaced but a new layer entry was still being created. This implied all label images were available but that is not the case. If the label image is changed the label image layer is simply updated now.
|
🎉 This PR is included in version 14.42.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR adds a button that allows the user to toggle on/off a label image bounding box. This will be useful when trying to visualize the actual bounds of a label image when it is not rendered as expected.
This currently only adds this feature for the label image. This can be changed if the feature should be available for all images (moving, fixed, label, etc).This now supports displaying the bounding box for any image layer.Currently a draft - Relies on InsightSoftwareConsortium/itk-viewer-icons#5.Should help with InsightSoftwareConsortium/itkwidgets#662 and InsightSoftwareConsortium/itkwidgets#663.