Ensure javascript files get the correct mimetype #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psavery
force-pushed
the
javascript-mimetypes
branch
from
f1634c8
to
605c883
Compare
On Windows, the mimetypes are obtained from the registry. However, the mimetype for javascript files is broken. Add some code to ensure that javascript files are identified correctly. This also adds some infrastructure for adding extra mimetypes that persist even if `mimetypes.init()` is called. Signed-off-by: Patrick Avery <[email protected]>
psavery
force-pushed
the
javascript-mimetypes
branch
from
605c883
to
40a9618
Compare
jourdain
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, the mimetypes are obtained from the registry. However,
the mimetype for javascript files is broken. Add some code to ensure
that javascript files are identified correctly.
This also adds some infrastructure for adding extra mimetypes that
persist even if
mimetypes.init()is called.This fixes the issue that I was encountering on Windows.