Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lpc176x ssp1 #2393

Merged
merged 9 commits into from
Jan 15, 2020
Merged

Lpc176x ssp1 #2393

merged 9 commits into from
Jan 15, 2020

Conversation

akatik
Copy link
Contributor

@akatik akatik commented Jan 14, 2020

lpc176x: Add ssp1 SPI

Makerbase MKS SGEN L board uses ssp1 on pins P0.8, P0.9 and P0.7 for display connection.

Signed-off-by: Andrey Kovalev [email protected]

@KevinOConnor
Copy link
Collaborator

Thanks. However, this would ideally be something done at runtime instead of at compile-time. For an example of how runtime selection can be implemented, see src/stm32/spi.c .

-Kevin

@akatik
Copy link
Contributor Author

akatik commented Jan 14, 2020

Rewrite. No configuration at compile time and one more line into printer.cfg:
spi_bus = ssp1
klippy.log

@KevinOConnor KevinOConnor merged commit b3c3b61 into Klipper3d:master Jan 15, 2020
@KevinOConnor
Copy link
Collaborator

Thanks!

-Kevin

@akatik akatik deleted the lpc176x-ssp1 branch January 15, 2020 09:26
FHeilmann pushed a commit to FHeilmann/klipper that referenced this pull request Jan 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants