-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Ender 2 Pro config #5359
Adds Ender 2 Pro config #5359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove all the following lines unless they come stock on this printer and fix the USART pins in the firmware make comments.
- 28
- 29
- 53
- 54
- 70
- 82
- 103
- 104
- 116-130
Will do, thank you for reviewing. Documenting for posterity. If anyone else stumbles on this and wants to add BLTouch, change the following settings (or look at my specific settings here )
Pinouts derived from here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still need to add the Signed-off-by line in your initial opening comment and need a blank newline at the end of your config otherwise the check will fail.
I've made the requested changes, squashed commits, fixed the Signed-off-by line and re-read the Contributing document. |
Looks good to me just need to wait for someone with the actual authority to merge this. |
Adds a default config for Ender 2 Pro. Printer uses creality 4.2.3 board Signed-off-by: Spencer Owen [email protected]
Thanks. It looks fine to me, but please add it to the printers.test test cases (point 4 at https://www.klipper3d.org/Example_Configs.html ). -Kevin |
Signed-off-by: Spencer Owen [email protected]
printers.test test cases added |
Thanks. -Kevin |
Adds a default config for ender 2 pro. See previous pull request for additional details.
I've tested this and it works for me.
Signed-off-by: Spencer Owen [email protected]