Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Ender 2 Pro config #5359

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Adds Ender 2 Pro config #5359

merged 2 commits into from
Mar 18, 2022

Conversation

spuder
Copy link
Contributor

@spuder spuder commented Mar 16, 2022

Adds a default config for ender 2 pro. See previous pull request for additional details.

I've tested this and it works for me.

Signed-off-by: Spencer Owen [email protected]

@spuder
Copy link
Contributor Author

spuder commented Mar 16, 2022

There are these 2 warnings in the fluidd gui.

I'm optimizing for consistency here. Since no other example configs have these 2 values defined, I'm intentionally omitting them from this pull request.

Screen Shot 2022-03-15 at 9 34 40 PM

Copy link
Contributor

@Fisheiyy Fisheiyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove all the following lines unless they come stock on this printer and fix the USART pins in the firmware make comments.

  • 28
  • 29
  • 53
  • 54
  • 70
  • 82
  • 103
  • 104
  • 116-130

@spuder
Copy link
Contributor Author

spuder commented Mar 16, 2022

Will do, thank you for reviewing.

Documenting for posterity. If anyone else stumbles on this and wants to add BLTouch, change the following settings (or look at my specific settings here )

[stepper_x]
position_min: -11
position_endstop: -11

[stepper_z]
endstop_pin: probe:z_virtual_endstop
position_min: -5.0

[bltouch]
sensor_pin: ^PB1
control_pin: PB0
x_offset: -30
y_offset: 2
z_offset: 2

[safe_z_home]
home_xy_position: 83, 83 # Change coordinates to the center of your print bed
speed: 50
z_hop: 10
z_hop_speed: 10

Pinouts derived from here:

Copy link
Contributor

@Fisheiyy Fisheiyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need to add the Signed-off-by line in your initial opening comment and need a blank newline at the end of your config otherwise the check will fail.

@spuder
Copy link
Contributor Author

spuder commented Mar 16, 2022

I've made the requested changes, squashed commits, fixed the Signed-off-by line and re-read the Contributing document.
I think this change is ready. Please let me know if I missed anything.

@Fisheiyy
Copy link
Contributor

Looks good to me just need to wait for someone with the actual authority to merge this.

Adds a default config for Ender 2 Pro. Printer uses creality 4.2.3 board

Signed-off-by: Spencer Owen [email protected]
@KevinOConnor
Copy link
Collaborator

Thanks. It looks fine to me, but please add it to the printers.test test cases (point 4 at https://www.klipper3d.org/Example_Configs.html ).

-Kevin

@KevinOConnor KevinOConnor added the pending feedback Topic is pending feedback from submitter label Mar 17, 2022
Signed-off-by: Spencer Owen [email protected]
@spuder
Copy link
Contributor Author

spuder commented Mar 18, 2022

printers.test test cases added

@KevinOConnor KevinOConnor merged commit 743c766 into Klipper3d:master Mar 18, 2022
@KevinOConnor
Copy link
Collaborator

Thanks.

-Kevin

@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pending feedback Topic is pending feedback from submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants