Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper pluralization for paths #179

Conversation

cweedall
Copy link
Contributor

@cweedall cweedall commented May 9, 2024

The existing pluralization is basically a rubber stamp method of adding s onto the word. I noticed this pluralizes words which have a different pluralization requirement, such as University, incorrectly (e.g. Universitys). It also supports other less-common pluralization, such as sex/sexes, ox/oxen, etc.

This can be corrected manually after OpenAPI generation for small ontologies. But it is unwieldy for larger ones.

Upon investigating tools that we could use to pluralize, I was shocked that Java does not support this well compared to many other programming/scripting languages. I could only find ones that handle English, and there were only a few tools available (some have not been updated for many years). Because it was currently only adding s, and I assume it was English-centric for this purpose(?), I settled with JiBX tools. JiBX tools was updated as recently as late 2022.

@mosoriob mosoriob merged commit e572ebb into KnowledgeCaptureAndDiscovery:master May 9, 2024
3 checks passed
@dgarijo
Copy link
Contributor

dgarijo commented May 9, 2024

This one is awesome, we never had enough time to look around and include it.

@cweedall cweedall deleted the feature/proper-pluralization-for-paths branch May 9, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants