Add support for Doctrine ORMv3/DBALv4 #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W0rma
commented
Apr 22, 2024
Comment on lines
24
to
36
| //reset count orderBy since it can break query and slow it down | ||
| $qb | ||
| ->resetQueryPart('orderBy') | ||
| ; | ||
|
|
||
| if (method_exists($qb, 'resetOrderBy')) { | ||
| $qb->resetOrderBy(); | ||
| } else { | ||
| $qb->resetQueryParts(['orderBy']); | ||
| } | ||
|
|
||
| // get the query | ||
| $sql = $qb->getSQL(); | ||
|
|
||
| $qb | ||
| ->resetQueryParts() | ||
| ->select('count(*) as cnt') | ||
| ->from('(' . $sql . ')', 'dbal_count_tbl') | ||
| ; |
There was a problem hiding this comment.
resetQueryParts() has been removed in DBALv4.
Removing ->from() makes the test pipeline green.
However, I'm not sure if this could cause any side effects.
Without this change $qb->getSQL() would return SELECT count(*) as cnt FROM Article a, (SELECT * FROM Article a) dbal_count_tbl which would lead to the result 16 instead of 4
In master, $qb->getSQL() returns SELECT count(*) as cnt FROM (SELECT * FROM Article a) dbal_count_tbl.
…Manager is public
…rts() is not available anymore in newer DBAL versions
Fixes the prefer-lowest test pipeline
garak
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built on top of #331 and tries to fix the remaining compatibility issues.
Fixes #328