Add encode_to API
#66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another alternative is to just make |
cgwalters
commented
Dec 17, 2021
cgwalters
force-pushed
the
encode-to
branch
2 times, most recently
from
d6d0122
to
8df0405
Compare
|
OK this is also much cleaner using |
To fix CI for git main/master.
In https://github.com/ostreedev/ostree-rs-ext/ we are performing hex encoding in loops and recursively, and it could be helpful for performance to support re-using a buffer instead of allocating a new `String` on the heap. Currently we are using `encode_to_slice`, but then we need to use e.g. `std::str::from_utf8` which unnecessarily performs UTF-8 validation and is also hence fallible even though it doesn't need to be.
|
I rolled in #67 here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/ostreedev/ostree-rs-ext/ we are performing
hex encoding in loops and recursively, and it could be helpful
for performance to support re-using a buffer instead of allocating
a new
Stringon the heap.Currently we are using
encode_to_slice, but then we need touse e.g.
std::str::from_utf8which unnecessarily performs UTF-8validation and is also hence fallible even though it doesn't need to be.