-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[draft] Good support for NewComputerModern font #67
Conversation
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
- Coverage 81.88% 78.50% -3.39%
==========================================
Files 9 7 -2
Lines 508 442 -66
==========================================
- Hits 416 347 -69
- Misses 92 95 +3
Continue to review full report at Codecov.
|
@jkrumbiegel Everything should be okay, but I didn't manage to run Makie tests with your PR and this one (everytime I forgot or to do it properly x_x). If everything looks fine to you, I'll merge and tag a new version. |
Thanks a lot for the feedback and the reference image @jkrumbiegel Merging now. |
Reintroduce support for NewComputerModern which as better support for unicode and should have all glyphs we'll ever need.
Should help with #44, #46, #49 and #57.
Require the awesome work of @jkrumbiegel in JuliaGraphics/FreeTypeAbstraction.jl#72 and MakieOrg/Makie.jl#2139
Require some work to avoid reintroducing #26