Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement \overline command #80

Merged
merged 2 commits into from
Oct 2, 2022
Merged

implement \overline command #80

merged 2 commits into from
Oct 2, 2022

Conversation

karlwessel
Copy link

I implemented the support for the overline command basically by pattern recognition of how the \sqrt implementation works. I can't say I fully understood every line, therefore it would be good if somebody can double check if I missed something. Especially the layout part.

Also added basic tests for parsers and layouts handling of overline.

This fixes issue #79.

add tests for parsers and layouts handling of overline
implement \overline command similiar to square root
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2022

Codecov Report

Base: 79.78% // Head: 80.25% // Increases project coverage by +0.46% 🎉

Coverage data is based on head (c590bf4) compared to base (50f8b4c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   79.78%   80.25%   +0.46%     
==========================================
  Files           7        7              
  Lines         470      476       +6     
==========================================
+ Hits          375      382       +7     
+ Misses         95       94       -1     
Impacted Files Coverage Δ
src/parser/commands_registration.jl 34.78% <ø> (ø)
src/engine/layout.jl 90.07% <100.00%> (+0.47%) ⬆️
src/engine/texelements.jl 81.57% <0.00%> (+1.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@Kolaru Kolaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this !

Overall this is very good pattern recognition, thanks in particular for taking time to add tests.

The changes are just minor style and layouting changes.

src/engine/layout.jl Outdated Show resolved Hide resolved
src/engine/layout.jl Outdated Show resolved Hide resolved
Copy link
Owner

@Kolaru Kolaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect, thanks a lot.

@Kolaru Kolaru merged commit 7229d74 into Kolaru:master Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants