catch error from howler #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devashishmamgain
previously approved these changes
Jul 25, 2019
CaptainT33mo
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do you want to achieve?
-> TypeError: null is not an object (evaluating 'o.ctx.createGain') is thorwing on Safari sometimes. due to this error plugin is not loading.
goldfire/howler.js#1021
the plugin should load if any error throw from howler library
How was the code tested?
-> created a sample webpage and loaded plugin multiple times on different tabs using the link button
What new thing you came across while writing this code?
->
Incase you fixed a bug then please describe the root cause of it?
->
NOTE: Make sure you're comparing your branch with the correct base branch