Fix TestDestroy.TestDestroyTensorSingle #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata to the device Signed-off-by: ScheissSchiesser <[email protected]>
photon-schiesser
force-pushed
the
fix_testDestroyTensorSingle
branch
from
4c546f6
to
409c455
Compare
photon-schiesser
commented
Apr 9, 2022
axsaucedo
requested changes
Apr 10, 2022
Signed-off-by: ScheissSchiesser <[email protected]>
photon-schiesser
force-pushed
the
fix_testDestroyTensorSingle
branch
from
65be60f
to
54baa18
Compare
|
NIce one @ScheissSchiesser - thank you for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes this test by first syncing the tensor data to the device. When I run the test suite multiple times on my real hardware, the memory on the device was never initialized, so the test would fail on the first run, then succeed, then fail thereafter.