fix(o2k): limit path-param names to 32 chars #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the path-parameter-names need to be predictable, because they might reuse them in other places (request-transformer template for example). So truncation or truncation and replacing the last x-chars with a hash for uniqueness, will not work, since the names become unpredictable. Then I think the only alternative is to throw an error in OAS2kong, and have the user preprocess them to shorter names, such that they are well informed about the new names in use. More work, but no surprises.
|
working on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PCRE engines have a limit of 32 characters.
the path-parameter-names need to be predictable, because they might reuse them in other places (request-transformer template for example). So truncation or truncation and replacing the last x-chars with a hash for uniqueness, will not work, since the names become unpredictable.
Then I think the only alternative is to throw an error in OAS2kong, and have the user preprocess them to shorter names, such that they are well informed about the new names in use. More work, but no surprises.