feat: updating javascript targets to use const instead of var

src/targets/javascript/fetch.js

@@ -44,7 +44,7 @@ module.exports = function (source, options) {
       break
 
     case 'multipart/form-data':
-      code.push('var form = new FormData();')
+      code.push('const form = new FormData();')
 
       source.postData.params.forEach(function (param) {
         code.push(

src/targets/javascript/jquery.js

@@ -38,7 +38,7 @@ module.exports = function (source, options) {
       break
 
     case 'multipart/form-data':
-      code.push('var form = new FormData();')
+      code.push('const form = new FormData();')
 
       source.postData.params.forEach(function (param) {
         code.push('form.append(%s, %s);', JSON.stringify(param.name), JSON.stringify(param.value || param.fileName || ''))
@@ -62,7 +62,7 @@ module.exports = function (source, options) {
       }
   }
 
-  code.push('var settings = ' + JSON.stringify(settings, null, opts.indent).replace('"[form]"', 'form'))
+  code.push('const settings = ' + JSON.stringify(settings, null, opts.indent).replace('"[form]"', 'form') + ';')
       .blank()
       .push('$.ajax(settings).done(function (response) {')
       .push(1, 'console.log(response);')

src/targets/javascript/xhr.js

@@ -22,12 +22,12 @@ module.exports = function (source, options) {
 
   switch (source.postData.mimeType) {
     case 'application/json':
-      code.push('var data = JSON.stringify(%s);', JSON.stringify(source.postData.jsonObj, null, opts.indent))
+      code.push('const data = JSON.stringify(%s);', JSON.stringify(source.postData.jsonObj, null, opts.indent))
           .push(null)
       break
 
     case 'multipart/form-data':
-      code.push('var data = new FormData();')
+      code.push('const data = new FormData();')
 
       source.postData.params.forEach(function (param) {
         code.push('data.append(%s, %s);', JSON.stringify(param.name), JSON.stringify(param.value || param.fileName || ''))
@@ -42,11 +42,11 @@ module.exports = function (source, options) {
       break
 
     default:
-      code.push('var data = %s;', JSON.stringify(source.postData.text || null))
+      code.push('const data = %s;', JSON.stringify(source.postData.text || null))
           .blank()
   }
 
-  code.push('var xhr = new XMLHttpRequest();')
+  code.push('const xhr = new XMLHttpRequest();')
 
   if (opts.cors) {
     code.push('xhr.withCredentials = true;')

src/targets/node/native.js

@@ -28,20 +28,20 @@ module.exports = function (source, options) {
     headers: source.allHeaders
   }
 
-  code.push('var http = require("%s");', source.uriObj.protocol.replace(':', ''))
+  code.push('const http = require("%s");', source.uriObj.protocol.replace(':', ''))
 
   code.blank()
-      .push('var options = %s;', JSON.stringify(reqOpts, null, opts.indent))
+      .push('const options = %s;', JSON.stringify(reqOpts, null, opts.indent))
       .blank()
-      .push('var req = http.request(options, function (res) {')
-      .push(1, 'var chunks = [];')
+      .push('const req = http.request(options, function (res) {')
+      .push(1, 'const chunks = [];')
       .blank()
       .push(1, 'res.on("data", function (chunk) {')
       .push(2, 'chunks.push(chunk);')
       .push(1, '});')
       .blank()
       .push(1, 'res.on("end", function () {')
-      .push(2, 'var body = Buffer.concat(chunks);')
+      .push(2, 'const body = Buffer.concat(chunks);')
       .push(2, 'console.log(body.toString());')
       .push(1, '});')
       .push('});')
@@ -50,7 +50,7 @@ module.exports = function (source, options) {
   switch (source.postData.mimeType) {
     case 'application/x-www-form-urlencoded':
       if (source.postData.paramsObj) {
-        code.unshift('var qs = require("querystring");')
+        code.unshift('const qs = require("querystring");')
         code.push('req.write(qs.stringify(%s));', stringifyObject(source.postData.paramsObj, {
           indent: '  ',
           inlineCharacterLimit: 80

src/targets/node/request.js

@@ -22,7 +22,7 @@ module.exports = function (source, options) {
   var includeFS = false
   var code = new CodeBuilder(opts.indent)
 
-  code.push('var request = require("request");')
+  code.push("const request = require('request');")
       .blank()
 
   var reqOpts = {
@@ -90,21 +90,21 @@ module.exports = function (source, options) {
   if (source.cookies.length) {
     reqOpts.jar = 'JAR'
 
-    code.push('var jar = request.jar();')
+    code.push('const jar = request.jar();')
 
     var url = source.url
 
     source.cookies.forEach(function (cookie) {
-      code.push('jar.setCookie(request.cookie("%s=%s"), "%s");', encodeURIComponent(cookie.name), encodeURIComponent(cookie.value), url)
+      code.push("jar.setCookie(request.cookie('%s=%s'), '%s');", encodeURIComponent(cookie.name), encodeURIComponent(cookie.value), url)
     })
     code.blank()
   }
 
   if (includeFS) {
-    code.unshift('var fs = require("fs");')
+    code.unshift("const fs = require('fs');")
   }
 
-  code.push('var options = %s;', stringifyObject(reqOpts, { indent: '  ', inlineCharacterLimit: 80 }))
+  code.push('const options = %s;', stringifyObject(reqOpts, { indent: '  ', inlineCharacterLimit: 80 }))
     .blank()
 
   code.push(util.format('request(options, %s', 'function (error, response, body) {'))

src/targets/node/unirest.js

@@ -20,20 +20,20 @@ module.exports = function (source, options) {
   var includeFS = false
   var code = new CodeBuilder(opts.indent)
 
-  code.push('var unirest = require("unirest");')
+  code.push('const unirest = require("unirest");')
       .blank()
-      .push('var req = unirest("%s", "%s");', source.method, source.url)
+      .push('const req = unirest("%s", "%s");', source.method, source.url)
       .blank()
 
   if (source.cookies.length) {
-    code.push('var CookieJar = unirest.jar();')
+    code.push('const CookieJar = unirest.jar();')
 
     source.cookies.forEach(function (cookie) {
       code.push('CookieJar.add("%s=%s","%s");', encodeURIComponent(cookie.name), encodeURIComponent(cookie.value), source.url)
     })
 
     code.push('req.jar(CookieJar);')
-        .blank()
+      .blank()
   }
 
   if (Object.keys(source.queryObj).length) {
@@ -50,13 +50,15 @@ module.exports = function (source, options) {
     case 'application/x-www-form-urlencoded':
       if (source.postData.paramsObj) {
         code.push('req.form(%s);', JSON.stringify(source.postData.paramsObj, null, opts.indent))
+          .blank()
       }
       break
 
     case 'application/json':
       if (source.postData.jsonObj) {
         code.push('req.type("json");')
             .push('req.send(%s);', JSON.stringify(source.postData.jsonObj, null, opts.indent))
+            .blank()
       }
       break
 
@@ -84,20 +86,21 @@ module.exports = function (source, options) {
       })
 
       code.push('req.multipart(%s);', JSON.stringify(multipart, null, opts.indent))
+        .blank()
       break
 
     default:
       if (source.postData.text) {
-        code.push(opts.indent + 'req.send(%s);', JSON.stringify(source.postData.text, null, opts.indent))
+        code.push('req.send(%s);', JSON.stringify(source.postData.text, null, opts.indent))
+          .blank()
       }
   }
 
   if (includeFS) {
-    code.unshift('var fs = require("fs");')
+    code.unshift('const fs = require("fs");')
   }
 
-  code.blank()
-      .push('req.end(function (res) {')
+  code.push('req.end(function (res) {')
       .push(1, 'if (res.error) throw new Error(res.error);')
       .blank()
       .push(1, 'console.log(res.body);')

test/fixtures/output/javascript/fetch/multipart-data.js

@@ -1,4 +1,4 @@
-var form = new FormData();
+const form = new FormData();
 form.append("foo", "Hello World");
 
 fetch("http://mockbin.com/har", {

test/fixtures/output/javascript/fetch/multipart-file.js

@@ -1,4 +1,4 @@
-var form = new FormData();
+const form = new FormData();
 form.append("foo", "test/fixtures/files/hello.txt");
 
 fetch("http://mockbin.com/har", {

test/fixtures/output/javascript/fetch/multipart-form-data.js

@@ -1,4 +1,4 @@
-var form = new FormData();
+const form = new FormData();
 form.append("foo", "bar");
 
 fetch("http://mockbin.com/har", {

test/fixtures/output/javascript/jquery/application-form-encoded.js

@@ -1,4 +1,4 @@
-var settings = {
+const settings = {
   "async": true,
   "crossDomain": true,
   "url": "http://mockbin.com/har",
@@ -10,7 +10,7 @@ var settings = {
     "foo": "bar",
     "hello": "world"
   }
-}
+};
 
 $.ajax(settings).done(function (response) {
   console.log(response);

test/fixtures/output/javascript/jquery/application-json.js

@@ -1,4 +1,4 @@
-var settings = {
+const settings = {
   "async": true,
   "crossDomain": true,
   "url": "http://mockbin.com/har",
@@ -8,7 +8,7 @@ var settings = {
   },
   "processData": false,
   "data": "{\"number\":1,\"string\":\"f\\\"oo\",\"arr\":[1,2,3],\"nested\":{\"a\":\"b\"},\"arr_mix\":[1,\"a\",{\"arr_mix_nested\":{}}],\"boolean\":false}"
-}
+};
 
 $.ajax(settings).done(function (response) {
   console.log(response);

test/fixtures/output/javascript/jquery/cookies.js

@@ -1,12 +1,12 @@
-var settings = {
+const settings = {
   "async": true,
   "crossDomain": true,
   "url": "http://mockbin.com/har",
   "method": "POST",
   "headers": {
     "cookie": "foo=bar; bar=baz"
   }
-}
+};
 
 $.ajax(settings).done(function (response) {
   console.log(response);

test/fixtures/output/javascript/jquery/custom-method.js

@@ -1,10 +1,10 @@
-var settings = {
+const settings = {
   "async": true,
   "crossDomain": true,
   "url": "http://mockbin.com/har",
   "method": "PROPFIND",
   "headers": {}
-}
+};
 
 $.ajax(settings).done(function (response) {
   console.log(response);

test/fixtures/output/javascript/jquery/full.js

@@ -1,4 +1,4 @@
-var settings = {
+const settings = {
   "async": true,
   "crossDomain": true,
   "url": "http://mockbin.com/har?foo=bar&foo=baz&baz=abc&key=value",
@@ -11,7 +11,7 @@ var settings = {
   "data": {
     "foo": "bar"
   }
-}
+};
 
 $.ajax(settings).done(function (response) {
   console.log(response);

test/fixtures/output/javascript/jquery/headers.js

@@ -1,4 +1,4 @@
-var settings = {
+const settings = {
   "async": true,
   "crossDomain": true,
   "url": "http://mockbin.com/har",
@@ -7,7 +7,7 @@ var settings = {
     "accept": "application/json",
     "x-foo": "Bar"
   }
-}
+};
 
 $.ajax(settings).done(function (response) {
   console.log(response);

test/fixtures/output/javascript/jquery/https.js

@@ -1,10 +1,10 @@
-var settings = {
+const settings = {
   "async": true,
   "crossDomain": true,
   "url": "https://mockbin.com/har",
   "method": "GET",
   "headers": {}
-}
+};
 
 $.ajax(settings).done(function (response) {
   console.log(response);

test/fixtures/output/javascript/jquery/jsonObj-multiline.js

@@ -1,4 +1,4 @@
-var settings = {
+const settings = {
   "async": true,
   "crossDomain": true,
   "url": "http://mockbin.com/har",
@@ -8,7 +8,7 @@ var settings = {
   },
   "processData": false,
   "data": "{\n  \"foo\": \"bar\"\n}"
-}
+};
 
 $.ajax(settings).done(function (response) {
   console.log(response);

test/fixtures/output/javascript/jquery/jsonObj-null-value.js

@@ -1,4 +1,4 @@
-var settings = {
+const settings = {
   "async": true,
   "crossDomain": true,
   "url": "http://mockbin.com/har",
@@ -8,7 +8,7 @@ var settings = {
   },
   "processData": false,
   "data": "{\"foo\":null}"
-}
+};
 
 $.ajax(settings).done(function (response) {
   console.log(response);

test/fixtures/output/javascript/jquery/multipart-data.js

@@ -1,7 +1,7 @@
-var form = new FormData();
+const form = new FormData();
 form.append("foo", "Hello World");
 
-var settings = {
+const settings = {
   "async": true,
   "crossDomain": true,
   "url": "http://mockbin.com/har",
@@ -11,7 +11,7 @@ var settings = {
   "contentType": false,
   "mimeType": "multipart/form-data",
   "data": form
-}
+};
 
 $.ajax(settings).done(function (response) {
   console.log(response);

test/fixtures/output/javascript/jquery/multipart-file.js

@@ -1,7 +1,7 @@
-var form = new FormData();
+const form = new FormData();
 form.append("foo", "test/fixtures/files/hello.txt");
 
-var settings = {
+const settings = {
   "async": true,
   "crossDomain": true,
   "url": "http://mockbin.com/har",
@@ -11,7 +11,7 @@ var settings = {
   "contentType": false,
   "mimeType": "multipart/form-data",
   "data": form
-}
+};
 
 $.ajax(settings).done(function (response) {
   console.log(response);

test/fixtures/output/javascript/jquery/multipart-form-data.js

@@ -1,7 +1,7 @@
-var form = new FormData();
+const form = new FormData();
 form.append("foo", "bar");
 
-var settings = {
+const settings = {
   "async": true,
   "crossDomain": true,
   "url": "http://mockbin.com/har",
@@ -11,7 +11,7 @@ var settings = {
   "contentType": false,
   "mimeType": "multipart/form-data",
   "data": form
-}
+};
 
 $.ajax(settings).done(function (response) {
   console.log(response);