-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cleaner python requests json snippets #189
feat: cleaner python requests json snippets #189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution!
Just one minor note about the function documentation on buildString
@DMarby Updated that docblock, and since I copied that function from Once this library gets some Babel compilation, these string padding methods could probably removed in favor of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! I think a conflict was introduced by your other PR I just merged - #188 😅
@develohpanda I've fixed the merge conflict so this should be good to go. |
Hi @erunion, it looks like one of the tests from the merge conflict is now failing 🙁 just need to fix up the expected double-quotes in that I think! |
@develohpanda Oops, sorry about that. Fixed now. |
This cleans up the Python
requests
target snippets to:application/json
requests, we now build out Python-compatible dicts and pass those torequests
via thejson=payload
argument that it provides.false
,true
, andnull
are now being translated into the Python-proper literals ofFalse
,True
, andNone
.