Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug where FormData in the js fetch target wasn't applied #202

Merged
merged 5 commits into from
Apr 27, 2021

Conversation

erunion
Copy link
Contributor

@erunion erunion commented Jan 30, 2021

  • Fixes a bug in the JS fetch target where FormData was being set to a form variable but never actually inserted. into the body of the fetch call.
  • Stops the JS fetch target from setting an empty object of headers.
  • Slightly cleans up the noise around the actual fetch call and indents the promise handling.

@CLAassistant
Copy link

CLAassistant commented Jan 30, 2021

CLA assistant check
All committers have signed the CLA.

@jbwyme
Copy link

jbwyme commented Apr 16, 2021

Hey just wanted to check in on the status of this! I believe this is causing incorrect code to be generated in our ReadMe docs.

@erunion
Copy link
Contributor Author

erunion commented Apr 16, 2021

@jbwyme You've already got this fix if you're a ReadMe customer because we run a fork (http://npm.im/@readme/httpsnippet) that have these changes. What's the bug you're seeing?

@jbwyme
Copy link

jbwyme commented Apr 16, 2021

Ah gotcha, perhaps this is unrelated. Here's the loom I shared with support: https://www.loom.com/share/06da93107f4b40f88172d680507ac99d

@erunion
Copy link
Contributor Author

erunion commented Apr 16, 2021

@jbwyme Gotcha, that hit my desk yesterday.

@reynolek
Copy link
Contributor

Fixed merge conflict injected from the PR that removed node 8

@reynolek reynolek merged commit 200b1fd into Kong:master Apr 27, 2021
@erunion erunion deleted the fix/js-fetch-formdata branch April 28, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants