-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rfc: drop support for < Node 10 #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @erunion -- The change looks good. I am thinking of making this the v2
release so that people arent forced to upgrade to node 10 (although they really should be at least node 10!).
I want to do 1 more minor release with some changes that have been merged, and then I will merge this and release v2
We will also need to remove a Node 8 build check in travis. |
I resolved a conflict after merging another one of your PRs. |
@reynolek awesome ty |
The current earliest version of Node that HTTPSnippet targets is Node 4 which was EOL'd in 2018. Probably time to cut it loose.
engines
requirement to be >=10.url.parse
was deprecated in Node 11, andurlObj
is populated with that.url
dependency all together since it's just being used forurl.parse
andurl.format
. The new URL API should be able to be adequate.mocha
andstandard
to their latest versions now that we're no longer blocked by the node@4 requirement.pinkie-promise
dependency as it's not used anywhere anymore.