Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc: drop support for < Node 10 #204

Merged
merged 8 commits into from
Apr 27, 2021
Merged

rfc: drop support for < Node 10 #204

merged 8 commits into from
Apr 27, 2021

Conversation

erunion
Copy link
Contributor

@erunion erunion commented Jan 30, 2021

The current earliest version of Node that HTTPSnippet targets is Node 4 which was EOL'd in 2018. Probably time to cut it loose.

  • Zero changes to library functionality or usage.
  • Changes the engines requirement to be >=10.
    • One thing that'll need to be addressed at some point is that url.parse was deprecated in Node 11, and urlObj is populated with that.
    • We might be able to eschew the url dependency all together since it's just being used for url.parse and url.format. The new URL API should be able to be adequate.
  • Upgrades mocha and standard to their latest versions now that we're no longer blocked by the node@4 requirement.
  • Fixes a host of Standard issues that appeared with the upgrade.
  • Removes the pinkie-promise dependency as it's not used anywhere anymore.

Copy link
Contributor

@reynolek reynolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @erunion -- The change looks good. I am thinking of making this the v2 release so that people arent forced to upgrade to node 10 (although they really should be at least node 10!).

I want to do 1 more minor release with some changes that have been merged, and then I will merge this and release v2

@reynolek
Copy link
Contributor

reynolek commented Apr 5, 2021

We will also need to remove a Node 8 build check in travis.

@CLAassistant
Copy link

CLAassistant commented Apr 20, 2021

CLA assistant check
All committers have signed the CLA.

@reynolek
Copy link
Contributor

I resolved a conflict after merging another one of your PRs.

@erunion
Copy link
Contributor Author

erunion commented Apr 21, 2021

@reynolek awesome ty

@reynolek reynolek merged commit 03a44e6 into Kong:master Apr 27, 2021
@erunion erunion deleted the rfc/node-10 branch April 28, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants