Support Node v20 #333
Merged
Support Node v20 #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
itsikcircle
commented
Nov 30, 2023
erunion
reviewed
Nov 30, 2023
jackkav
approved these changes
Dec 4, 2023
|
cc @filfreire @dimitropoulos could you please help in review this PR? |
|
@itsikcircle Sorry, I'm just a frequent contributor and don't have any repository permissions here. |
|
Thank you @jackkav for merging this PR. Is it already published? |
|
@jackkav How can we get a new version including this change? |
|
@jackkav who should I reach out to publish new npm version including this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node v20.10.0 is the latest LTS, many projected that use this as dependency is blocked by the limitation of the node engine to v18 and below.
In this PR I'm adding the needed support for node v20 as it is supported out of the box.