Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flags): add new flags from Figma [MA-2937] #315

Merged
merged 6 commits into from
Jun 6, 2024

Conversation

mihai-peteu
Copy link
Contributor

@mihai-peteu mihai-peteu commented Jun 4, 2024

Summary

2-letter svg filenames based on ISO 3166-1 Alpha 2 codes:

https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2#Officially_assigned_code_elements

Screenshot 2024-06-04 at 13 35 33

@mihai-peteu mihai-peteu requested a review from a team as a code owner June 4, 2024 20:39
@CLAassistant
Copy link

CLAassistant commented Jun 4, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mihai-peteu mihai-peteu marked this pull request as draft June 4, 2024 21:14
@adamdehaven
Copy link
Member

Testing #316 in a host application; please hold on this PR

@mihai-peteu mihai-peteu marked this pull request as ready for review June 5, 2024 22:24
Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mihai-peteu mihai-peteu merged commit 66058a3 into main Jun 6, 2024
4 checks passed
@mihai-peteu mihai-peteu deleted the feat/ma-2937-use-country-flags-api-requests branch June 6, 2024 15:01
kongponents-bot pushed a commit that referenced this pull request Jun 6, 2024
# [1.12.0](v1.11.0...v1.12.0) (2024-06-06)

### Features

* **flags:** add new flags from Figma [MA-2937] ([#315](#315)) ([66058a3](66058a3))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants