Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*): add world-private icon #69

Merged
merged 2 commits into from
Sep 20, 2023
Merged

feat(*): add world-private icon #69

merged 2 commits into from
Sep 20, 2023

Conversation

portikM
Copy link
Member

@portikM portikM commented Sep 20, 2023

Summary

  1. Adds world-private icon
  2. In sandbox adds search query to route query params to make search results sharable (e.g. https://kong.github.io/icons/?search=World)

PR Checklist

  • Does not introduce dependencies
  • Functional: all changes do not break existing APIs and if so, bump major version.
  • Tests pass: check the output of yarn test
  • Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
  • Framework style: abides by the essential rules in Vue's style guide
  • Cleanliness: does not have formatting issues, unused code (e.g., console.logs, debugger), or leftover comments
  • Docs: includes a technically accurate README, uses JSDOC where appropriate

@portikM portikM self-assigned this Sep 20, 2023
DariaYeremina
DariaYeremina previously approved these changes Sep 20, 2023
View reviewed changes
@portikM portikM enabled auto-merge (squash) September 20, 2023 19:28
@portikM portikM enabled auto-merge (squash) September 20, 2023 19:41
@portikM portikM merged commit 0998c42 into main Sep 20, 2023
3 checks passed
@portikM portikM deleted the feat/world-private-icon branch September 20, 2023 20:07
kongponents-bot pushed a commit that referenced this pull request Sep 20, 2023
@semantic-release-bot
chore(release): 1.6.0 [skip ci]
15308f2 
# [1.6.0](v1.5.0...v1.6.0) (2023-09-20)

### Features

* add world-private icon ([#69](#69)) ([0998c42](0998c42))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillztom jillztom jillztom approved these changes

@DariaYeremina DariaYeremina DariaYeremina left review comments

@adamdehaven adamdehaven Awaiting requested review from adamdehaven adamdehaven is a code owner

Assignees

@portikM portikM

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@portikM @kongponents-bot @adamdehaven @jillztom @DariaYeremina