-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: simplify ca cert handling for app and inso #4738
Conversation
aa2b307
to
34b99bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice. I honestly forgot that we already got the node-libcurl side of things done :)
f754bd0
to
9da7ef0
Compare
"build:app": "esr --cache ./scripts/build.ts --noErrorTruncation", | ||
"build:main.min.js": "cross-env NODE_ENV=development esr esbuild.main.ts", | ||
"build:sr": "npm run generate:ca-certs && esr esbuild.sr.ts", | ||
"build:sr": " esr esbuild.sr.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jackkav sorry I didn't catch this in time, but maybe get rid of the extra space before esr
in a future PR some time if you remember it.
The first request could be getting blocked by file writes, this process is avoided by using the CAINFO_BLOB feature of node-libcurl
Moves ca cert loading outside of the request path to main app start and inso send-request.os.tmpdir()
rather than stubbing electron to point at os.tmpdir()os.tmpdir()
for consistency.Future work
Closes INS-1511