fix: redirect redirect/returnLink with query
#129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekolab
force-pushed
the
fix/redirect-path
branch
2 times, most recently
from
8640353
to
6bd5686
Compare
Previously we always wrap the redirect link with `{ path }`,
causing query string lost when performing the redirect.
Support for `returnLink` in the URL query are also removed since
they are not used anymore
(adopted from Kong/kong-admin#2941)
nekolab
force-pushed
the
fix/redirect-path
branch
from
6bd5686
to
6aa2939
Compare
Leopoldthecoder
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we always wrap the redirect link with
{ path }, causing query string lost when performing the redirect.Support for
returnLinkin the URL query are also removed since they are not used anymorePR reference
ref: https://github.com/Kong/kong-admin/pull/2941