Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*): add data plane nodes page #214

Merged
merged 1 commit into from
Apr 27, 2024
Merged

feat(*): add data plane nodes page #214

merged 1 commit into from
Apr 27, 2024

Conversation

Leopoldthecoder
Copy link
Member

@Leopoldthecoder Leopoldthecoder commented Apr 22, 2024 •
edited
Loading

Summary

Adding DP nodes page and dynamic log leveling functionality.

Issue reference

KM-114

@Leopoldthecoder Leopoldthecoder force-pushed the feat/dp-nodes branch 3 times, most recently from 5e2faff to 03ba6a4 Compare April 22, 2024 06:38
@Leopoldthecoder Leopoldthecoder force-pushed the feat/dp-nodes branch 16 times, most recently from 82099d3 to 38906df Compare April 25, 2024 04:40
@Leopoldthecoder Leopoldthecoder force-pushed the feat/dp-nodes branch 2 times, most recently from baa5bdf to f5b2619 Compare April 25, 2024 07:26
sumimakito
sumimakito reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@sumimakito sumimakito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested and worked as expected. LGTM.
Let's wait until the PR package is ready.

raoxiaoyan
raoxiaoyan reviewed Apr 25, 2024
View reviewed changes
src/locales/en.json Outdated Show resolved Hide resolved
raoxiaoyan
raoxiaoyan reviewed Apr 25, 2024
View reviewed changes
Copy link
Contributor

@raoxiaoyan raoxiaoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, it would be better to show the hostname of the DP instead of ID
image

raoxiaoyan
raoxiaoyan approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@raoxiaoyan raoxiaoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and local manual test.

@Leopoldthecoder Leopoldthecoder marked this pull request as ready for review April 26, 2024 10:42
@Leopoldthecoder Leopoldthecoder merged commit 54b9232 into main Apr 27, 2024
20 checks passed
@Leopoldthecoder Leopoldthecoder deleted the feat/dp-nodes branch April 27, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumimakito sumimakito sumimakito left review comments

@raoxiaoyan raoxiaoyan raoxiaoyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Leopoldthecoder @sumimakito @raoxiaoyan