Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(*): replace utility classes and css vars #77

Merged
merged 7 commits into from
Aug 18, 2023
Merged

refactor(*): replace utility classes and css vars #77

merged 7 commits into from
Aug 18, 2023

Conversation

sumimakito
Copy link
Member

@sumimakito sumimakito commented Aug 15, 2023 •
edited
Loading

Summary

  • Replacing utility classes and CSS variables with design tokens and custom classes
  • Adding ESLint rules for utility classes
  • Adding Stylelint for CSS variables

KAG-2356

@sumimakito sumimakito marked this pull request as ready for review August 16, 2023 02:23
@sumimakito sumimakito marked this pull request as draft August 16, 2023 02:30
@sumimakito sumimakito marked this pull request as ready for review August 16, 2023 02:38
@sumimakito sumimakito marked this pull request as draft August 16, 2023 02:39
@sumimakito sumimakito marked this pull request as ready for review August 16, 2023 07:04
@sumimakito sumimakito marked this pull request as draft August 16, 2023 07:08
@sumimakito sumimakito marked this pull request as ready for review August 16, 2023 07:49
@Leopoldthecoder
Copy link
Member

Could you add @kong/design-tokens to the dependabot rule?

@sumimakito
Copy link
Member Author

@Leopoldthecoder @kong/design-tokens was added to dependabot rules. Thanks.

Leopoldthecoder
Leopoldthecoder approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Leopoldthecoder Leopoldthecoder merged commit 0ad4888 into main Aug 18, 2023
17 checks passed
@Leopoldthecoder Leopoldthecoder deleted the refactor/design-token branch August 18, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leopoldthecoder Leopoldthecoder Leopoldthecoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sumimakito @Leopoldthecoder