Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(request-terminator): add the missing captures in the echo #10390

Merged
merged 3 commits into from
Mar 7, 2023
Merged

fix(request-terminator): add the missing captures in the echo #10390

merged 3 commits into from
Mar 7, 2023

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Feb 28, 2023

Summary

request terminator 'echo' option would not return the uri-captures. And when it did, the array part was not returned as an array.

@Tieske
fix(request-terminator): add the missing captures in the echo
22d9bdf
@Tieske
fix(pdk) request.get_uri_captures now returns unnamed as an array
6e5a4f3 
the 'unnamed' entry was a regular Lua table, by adding the array_mt
it can be exported as an array even if empty
@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 28, 2023
hbagdi
hbagdi approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@hbagdi hbagdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need someone else with more experience with PDK to approve.

@hbagdi hbagdi requested a review from jschmid1 March 1, 2023 19:03
@hanshuebner
Copy link
Contributor

@jschmid1 Can you have a look, please?

@jschmid1 jschmid1 self-assigned this Mar 6, 2023
@jschmid1
Copy link
Contributor

jschmid1 commented Mar 6, 2023

Scheduling for tomorrow

jschmid1
jschmid1 approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@jschmid1 jschmid1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my main concern would've been testing more complex capture groups within the plugin but I see that the PDK tests cover this scenario.

@hanshuebner hanshuebner merged commit 406e61f into master Mar 7, 2023
@hanshuebner hanshuebner deleted the feat/reqterm branch March 7, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschmid1 jschmid1 jschmid1 approved these changes

@hbagdi hbagdi hbagdi approved these changes

Assignees

@jschmid1 jschmid1

Labels
changelog core/pdk plugins/request-termination size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tieske @hanshuebner @jschmid1 @hbagdi