Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump lua-protobuf to 0.4.2 #10413

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Conversation

vm-001
Copy link
Contributor

@vm-001 vm-001 commented Mar 2, 2023

Summary

Bump lua-protobuf from 0.3.3 to 0.4.2.

It has been confirmed that the lua-protobuf under version 0.4.2 causes the Segmentation fault(core dump) while used with lpeg. The issue was found in another PR(#10055).

Here is the proof in the core dump file on GitHub action runner.

Backtrace from the core dump
gdb /home/runner/work/kong/kong/bazel-bin/build/kong-dev/openresty/nginx/sbin/nginx /tmp/cores/core.nginx.30260

GNU gdb (Ubuntu 12.1-0ubuntu1~22.04) 12.1                                                                                                                                                                                                                  │····
Copyright (C) 2022 Free Software Foundation, Inc.                                                                                                                                                                                                          │····
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>                                                                                                                                                                              │····
This is free software: you are free to change and redistribute it.                                                                                                                                                                                         │····
There is NO WARRANTY, to the extent permitted by law.                                                                                                                                                                                                      │····
Type "show copying" and "show warranty" for details.                                                                                                                                                                                                       │····
This GDB was configured as "x86_64-linux-gnu".                                                                                                                                                                                                             │····
Type "show configuration" for configuration details.                                                                                                                                                                                                       │····
For bug reporting instructions, please see:                                                                                                                                                                                                                │····
<https://www.gnu.org/software/gdb/bugs/>.                                                                                                                                                                                                                  │····
Find the GDB manual and other documentation resources online at:                                                                                                                                                                                           │····
    <http://www.gnu.org/software/gdb/documentation/>.                                                                                                                                                                                                      │····
                                                                                                                                                                                                                                                           │····
For help, type "help".                                                                                                                                                                                                                                     │····
Type "apropos word" to search for commands related to "word"...                                                                                                                                                                                            │····
Reading symbols from /home/runner/work/kong/kong/bazel-bin/build/kong-dev/openresty/nginx/sbin/nginx...                                                                                                                                                    │····
                                                                                                                                                                                                                                                           │····
warning: Can't open file /dev/zero (deleted) during file-backed mapping note processing                                                                                                                                                                    │····
[New LWP 30260]                                                                                                                                                                                                                                            │····
[Thread debugging using libthread_db enabled]                                                                                                                                                                                                              │····
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".                                                                                                                                                                                 │····
Core was generated by `nginx: worker process                                                         '.                                                                                                                                                    │····
Program terminated with signal SIGSEGV, Segmentation fault.                                                                                                                                                                                                │····
#0  0x00007f98a3b9c1de in pb_free.part () from /home/runner/work/kong/kong/bazel-bin/build/kong-dev/lib/lua/5.1/pb.so                                                                                                                                      │····
(gdb) backtrace                                                                                                                                                                                                                                            │····
#0  0x00007f98a3b9c1de in pb_free.part () from /home/runner/work/kong/kong/bazel-bin/build/kong-dev/lib/lua/5.1/pb.so                                                                                                                                      │····
#1  0x00007f98a3b9cded in Lpb_delete () from /home/runner/work/kong/kong/bazel-bin/build/kong-dev/lib/lua/5.1/pb.so                                                                                                                                        │····
#2  0x00007f98b8b5bb93 in lj_BC_FUNCC () from /home/runner/work/kong/kong/bazel-bin/build/kong-dev/openresty/luajit/lib/libluajit-5.1.so.2                                                                                                                 │····
#3  0x00007f98b8b5e39f in gc_call_finalizer (g=0x561f8b098d10, L=L@entry=0x561f8b098ca0, mo=<optimized out>, o=0x561f8b4c70e0) at lj_gc.c:520                                                                                                              │····
#4  0x00007f98b8b5e688 in gc_finalize (L=L@entry=0x561f8b098ca0) at lj_gc.c:567                                                                                                                                                                            │····
#5  0x00007f98b8b5fe78 in lj_gc_finalize_udata (L=L@entry=0x561f8b098ca0) at lj_gc.c:574                                                                                                                                                                   │····
#6  0x00007f98b8b69a6e in cpfinalize (L=0x561f8b098ca0, dummy=<optimized out>, ud=<optimized out>) at lj_state.c:273                                                                                                                                       │····
#7  0x00007f98b8b5bf89 in lj_vm_cpcall () from /home/runner/work/kong/kong/bazel-bin/build/kong-dev/openresty/luajit/lib/libluajit-5.1.so.2                                                                                                                │····
#8  0x00007f98b8b69e58 in lua_close (L=0x561f8b098ca0) at lj_state.c:299                                                                                                                                                                                   │····
#9  0x0000561f89fffec7 in ngx_http_lua_cleanup_vm ()                                                                                                                                                                                                       │····
#10 0x0000561f89f14536 in ngx_destroy_pool ()                                                                                                                                                                                                              │····
#11 0x0000561f89f3f653 in ngx_worker_process_exit ()                                                                                                                                                                                                       │····
#12 0x0000561f89f3f863 in ngx_worker_process_cycle ()                                                                                                                                                                                                      │····
#13 0x0000561f89f3dbf6 in ngx_spawn_process ()                                                                                                                                                                                                             │····
#14 0x0000561f89f3eae8 in ngx_start_worker_processes ()                                                                                                                                                                                                    │····
#15 0x0000561f89f4053a in ngx_master_process_cycle ()                                                                                                                                                                                                      │····
#16 0x0000561f89f11ed5 in main () 

@vm-001 vm-001 marked this pull request as ready for review March 2, 2023 05:42
@StarlightIbuki StarlightIbuki self-assigned this Mar 2, 2023
@fffonion fffonion merged commit bcab9aa into master Mar 2, 2023
@fffonion fffonion deleted the chore/upgrade-lua-protobuf branch March 2, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants