Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vault): sticky configuration #10776

Merged
merged 1 commit into from
May 8, 2023
Merged

fix(vault): sticky configuration #10776

merged 1 commit into from
May 8, 2023

Conversation

bungle
Copy link
Member

@bungle bungle commented May 2, 2023

Summary

Fix a sticky vault configuration bug.

KAG-954

Copy link
Contributor

@flrgh flrgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple comments/concerns to discuss, but overall so far so good 👍

kong/clustering/compat/checkers.lua Outdated Show resolved Hide resolved
kong/pdk/vault.lua Outdated Show resolved Hide resolved
kong/pdk/vault.lua Outdated Show resolved Hide resolved
kong/pdk/vault.lua Outdated Show resolved Hide resolved
spec/02-integration/13-vaults/04-echo_spec.lua Outdated Show resolved Hide resolved
kong/clustering/compat/checkers.lua Outdated Show resolved Hide resolved
kong/pdk/vault.lua Show resolved Hide resolved
kong/pdk/vault.lua Outdated Show resolved Hide resolved
kong/pdk/vault.lua Show resolved Hide resolved
kong/pdk/vault.lua Outdated Show resolved Hide resolved
kong/pdk/vault.lua Show resolved Hide resolved
kong/pdk/vault.lua Outdated Show resolved Hide resolved
spec/02-integration/13-vaults/04-echo_spec.lua Outdated Show resolved Hide resolved
@bungle bungle force-pushed the fix/vault-sticky branch 3 times, most recently from 0135374 to d92114e Compare May 5, 2023 08:54
@pull-request-size pull-request-size bot added size/L and removed size/XL labels May 5, 2023
@bungle bungle force-pushed the fix/vault-sticky branch 3 times, most recently from 5762795 to 972388b Compare May 5, 2023 11:02
@pull-request-size pull-request-size bot added size/XL and removed size/L labels May 5, 2023
@bungle bungle force-pushed the fix/vault-sticky branch 5 times, most recently from 8975fcc to f199519 Compare May 5, 2023 19:08
@jschmid1 jschmid1 self-requested a review May 8, 2023 08:04
kong/pdk/vault.lua Outdated Show resolved Hide resolved
Signed-off-by: Aapo Talvensaari <[email protected]>
Copy link
Contributor

@jschmid1 jschmid1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now, thanks for your patience @bungle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants