-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vault): sticky configuration #10776
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/clustering
core/pdk
core/proxy
schema-change-noteworthy
labels
May 2, 2023
flrgh
reviewed
May 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple comments/concerns to discuss, but overall so far so good 👍
jschmid1
requested changes
May 3, 2023
bungle
force-pushed
the
fix/vault-sticky
branch
3 times, most recently
from
May 5, 2023 08:54
0135374
to
d92114e
Compare
bungle
force-pushed
the
fix/vault-sticky
branch
3 times, most recently
from
May 5, 2023 11:02
5762795
to
972388b
Compare
bungle
force-pushed
the
fix/vault-sticky
branch
5 times, most recently
from
May 5, 2023 19:08
8975fcc
to
f199519
Compare
jschmid1
reviewed
May 8, 2023
Signed-off-by: Aapo Talvensaari <[email protected]>
jschmid1
approved these changes
May 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good now, thanks for your patience @bungle
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a sticky vault configuration bug.
KAG-954