Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router/expressions): http redirection can't work with "expressions" #11166

Merged
merged 9 commits into from
Jul 5, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Jul 3, 2023

Summary

KAG-1251

This is a follow up of #11082.

if route.protocols has only https, we will not add net.protocol to expression.
This will give the runloop a chance to check http redirection.

Note:
Now expressions does not support tcp/tls, so we skip these test cases.

Checklist

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

@chronolaw chronolaw marked this pull request as ready for review July 3, 2023 11:20
@dndx dndx force-pushed the fix/expressions_with_redirect branch from 4c80a96 to ab41b11 Compare July 5, 2023 09:49
@dndx dndx merged commit 17d3f7a into master Jul 5, 2023
@dndx dndx deleted the fix/expressions_with_redirect branch July 5, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants