-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(zipkin) include http path to span name #8150
Merged
mayocream
merged 6 commits into
Kong:master
from
yankun-li-kong:feat/zipkin-add-http-path
Apr 1, 2022
Merged
feat(zipkin) include http path to span name #8150
mayocream
merged 6 commits into
Kong:master
from
yankun-li-kong:feat/zipkin-add-http-path
Apr 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new parameter span_include_path to decide whether to include http path to span name. Add test case.
mayocream
reviewed
Feb 7, 2022
I think it is good to have the endpoint in Span name, see OpenTelemetry spec opentelemetry-specification/api.md at main · open-telemetry/opentelemetry-specification For example, here are potential span names for an endpoint that gets a hypothetical account information:
|
kikito
requested changes
Mar 23, 2022
…kin-add-http-path
kikito
approved these changes
Mar 25, 2022
This looks ok to me. Could you please include a line on the changelog before merging it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new parameter span_include_path to decide whether to include http path to span name.
Add test case.
Summary
This PR is based on Kong/kong-plugin-zipkin#124, Thanks @XinweiLiu28
Able to include HTTP path to span name for zipkin plugin
Full changelog
Add a new parameter
span_include_path
to decide whether to include HTTP path to span name.Add test case.
Issues resolved
Fix FTI-2842