fix(get): propagate next page size param #9029

[jacksjm]

Summary

Fixed to propagate size parameter to perform next request

Full changelog

• Fixed to propagate the size parameter to perform the next request, ensuring the same size in requests

Issue reference

Fix #9029

[CLAassistant]

All committers have signed the CLA.

[chronolaw]

Great Job, Thank you Jackson.

Because I am not familiar with admin api, I think that we need others to take a look then approve.

[jacksjm]

Great Job, Thank you Jackson.

Because I am not familiar with admin api, I think that we need others to take a look then approve.

Thanks @chronolaw. This is OK. could you tag a sponsor to review? I do not know them. Do you need to remove your change request?

[jacksjm]

@mayocream would you be on the admin api team for review?

[mayocream]

Hi, although it’s a small change, but a proper test case should be written to ensure the functionality works.

[jacksjm]

Hi, although it’s a small change, but a proper test case should be written to ensure the functionality works.

Thanks for your feedback @mayocream!!! I searched the admin_api tests for next_page validators but couldn't find them. I believe there is no validation on this return, if I am wrong please correct me. Do you have any validation suggestions for this scenario?

[mayocream]

Should be in this format:

< local next_page = offset and fmt("/%s?offset=%s%s",
---
> local next_page = offset and fmt("/%s?offset=%s%s%s",

[mayocream]

I think this would be a feature (although very small); I'll include @sumimakito in this topic to see if it is good for Kong Manager (UI).

[sumimakito]

@jacksjm Thank you for your work 🙌
@mayocream Yes - I believe this would benefit KM and other projects that rely on the next link in the response, as long as we can ensure this change would not break them.

dismiss as addressed

[fffonion]

@jacksjm Thanks for the contribution, this is now merged 🎉 !

[jacksjm]

@jacksjm Thanks for the contribution, this is now merged 🎉 !

I'm very glad to contribute!!!