Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): dyn upstream keepalive #9856

Merged
merged 5 commits into from
Mar 7, 2023
Merged

fix(core): dyn upstream keepalive #9856

merged 5 commits into from
Mar 7, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Dec 2, 2022 •
edited
Loading

Summary

See issue #9582,
Related PR: Kong/kong-build-tools#619
Ticket: KAG-294

Checklist

  • The Pull Request has tests
  • There's an entry in the CHANGELOG

Full changelog

  • add lua-rest-core and ngx-lua patch in build/openresty/patches
  • check debug log to verify keepalive
  • add reusing connection test case
  • add crc32 collision test case

Issue reference

Fix #[9582]

@chronolaw chronolaw changed the title fix(patches): dyn upstream keepalive (WIP) fix(core): dyn upstream keepalive (WIP) Dec 2, 2022
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Dec 4, 2022
@pull-request-size pull-request-size bot added size/XS and removed size/S labels Dec 4, 2022
@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Dec 4, 2022
@chronolaw chronolaw marked this pull request as ready for review December 4, 2022 23:39
@chronolaw chronolaw changed the title fix(core): dyn upstream keepalive (WIP) fix(core): dyn upstream keepalive Dec 5, 2022
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 5, 2022
@chronolaw chronolaw added core/balancer and removed chore Not part of the core functionality of kong, but still needed labels Dec 5, 2022
@github-actions github-actions bot added chore Not part of the core functionality of kong, but still needed and removed core/balancer labels Dec 5, 2022
@chronolaw chronolaw mentioned this pull request Dec 5, 2022
Closed
@github-actions github-actions bot removed the chore Not part of the core functionality of kong, but still needed label Dec 28, 2022
@mayocream
Copy link
Contributor

mayocream commented Dec 28, 2022 •
edited
Loading

@chronolaw I squashed and rebased the commits, to fix failing ci.

@chronolaw chronolaw added this to the 3.2 milestone Jan 9, 2023
@chronolaw chronolaw removed this from the 3.2 milestone Jan 30, 2023
@chronolaw chronolaw marked this pull request as draft February 1, 2023 01:52
@chronolaw chronolaw force-pushed the fix/dyn_upstream_keepalive branch 4 times, most recently from f13880e to 93476ad Compare February 6, 2023 03:48
@chronolaw chronolaw marked this pull request as ready for review February 6, 2023 03:50
@gung-rgb
Copy link

when do this fix to be released? We are wait it to apply for out environment😁

@chronolaw
Copy link
Contributor Author

when do this fix to be released? We are wait it to apply for out environment😁

I have the same feeling as you. Perhaps it will be released in Kong 3.3.

@chronolaw chronolaw added this to the 3.3 milestone Feb 17, 2023
@chronolaw chronolaw force-pushed the fix/dyn_upstream_keepalive branch 2 times, most recently from 50b51c2 to f5596bf Compare February 22, 2023 06:59
@hanshuebner hanshuebner merged commit 3cff949 into master Mar 7, 2023
@hanshuebner hanshuebner deleted the fix/dyn_upstream_keepalive branch March 7, 2023 05:30
oowl pushed a commit that referenced this pull request Aug 15, 2024
@team-gateway-bot @Water-Melon
feat(pdk): support unlimited body size for `kong.request.get_raw_body…
a9e01cc 
…()` (#9856)

This function will be used in EE.

KAG-4698

(cherry picked from commit #13431)

Co-authored-by: Niklaus Schen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oowl oowl oowl approved these changes

Assignees
No one assigned
Labels
build/bazel changelog size/XXL
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

There is a CRC32 collision for upstream pools
6 participants
@chronolaw @mayocream @gung-rgb @oowl @hanshuebner @ADD-SP