fix(db): add back FLOOR so ttl returns integer instead of float
#9960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chronolaw
approved these changes
Dec 14, 2022
|
Could we add a test case to catch this bug? |
We just add back a removed part, which has built-in test already. But also need verification from downstream clients that relies on |
|
We should add a change log entry too. |
1 task
1 task
outsinre
changed the title
FLOOR so ttl returns integer instead of float
chronolaw
changed the title
FLOOR so ttl returns integer instead of floatFLOOR so ttl returns integer instead of float
outsinre
force-pushed
the
FTI-4066-make-sure-integer-return
branch
from
2ed8e4f
to
f57af06
Compare
Done. |
dndx
approved these changes
Dec 14, 2022
Add back `FLOOR` so that `ttl` is returned as integer instead of float. PR <#9801> remove `FLOOR` part to reflect the real `ttl` value, but may return a `float` value instead of `int`, which would break some downstream clients as depicted in issue <#9944>. This PR add back `FLOOR` as in the `handler.lua`, we have double-check on `cred.ttl == 0`. So it is **safe** to add back. Fix #_[9944]_ and also check [FTI-4066].
outsinre
force-pushed
the
FTI-4066-make-sure-integer-return
branch
from
f57af06
to
791488e
Compare
dndx
reviewed
Dec 14, 2022
Co-authored-by: Datong Sun <[email protected]>
dndx
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add back
FLOORso thatttlis returned as integer instead of float.PR #9801 remove
FLOORpart to reflect the realttlvalue, but may return afloatvalue instead ofint, which would break some downstream clients as depicted in issue #9944.This PR add back
FLOORas in thehandler.lua, we have double-check oncred.ttl == 0. So it is safe to add back.Also check FTI-4066.
Issue reference
Fix #[9944]