-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(KPop, KPrompt, KRadio, KSegmentedControl): add types [KHCP-6971] #1292
Conversation
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
src/components/KSelect/KSelect.vue
Outdated
@@ -264,12 +265,13 @@ export type DropdownFooterTextPosition = 'sticky' | 'static' | |||
</script> | |||
|
|||
<script setup lang="ts"> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove empty line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
src/components/KRadio/KRadio.vue
Outdated
(e: 'change', value: string | boolean | number | object): void; | ||
(e: 'update:modelValue', value: string | boolean | number | object): void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: no semicolons needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
src/components/KRadio/KRadio.vue
Outdated
|
||
export default { | ||
inheritAttrs: false, | ||
} | ||
</script> | ||
|
||
<script setup lang="ts"> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove empty line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -277,6 +277,7 @@ export default { | |||
</script> | |||
|
|||
<script setup lang="ts"> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove empty line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
4d76563
to
41edbd5
Compare
41edbd5
to
27c4f6e
Compare
ae4f863
27c4f6e
to
ae4f863
Compare
🎉 This PR is included in version 8.53.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
https://konghq.atlassian.net/browse/KHCP-6971
Improve types for Popover, Propmt, Radio, Segmented Control
PR Checklist