Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(KPop, KPrompt, KRadio, KSegmentedControl): add types [KHCP-6971] #1292

Merged
merged 3 commits into from
Apr 20, 2023

Conversation

DariaYeremina
Copy link
Contributor

Summary

https://konghq.atlassian.net/browse/KHCP-6971
Improve types for Popover, Propmt, Radio, Segmented Control

PR Checklist

  • Does not introduce dependencies
  • Functional: all changes do not break existing APIs and if so, bump major version.
  • Tests pass: check the output of yarn test
  • Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
  • Framework style: abides by the essential rules in Vue's style guide
  • Cleanliness: does not have formatting issues, unused code (e.g., console.logs, debugger), or leftover comments
  • Docs: includes a technically accurate README, uses JSDOC where appropriate

@DariaYeremina DariaYeremina requested a review from a team as a code owner April 17, 2023 14:56
@DariaYeremina DariaYeremina self-assigned this Apr 17, 2023
@netlify
Copy link

netlify bot commented Apr 17, 2023

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit ae4f863
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/64414c4fef3aab000728c221
😎 Deploy Preview https://deploy-preview-1292--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@DariaYeremina DariaYeremina changed the title Feat/khcp 6971 feat(KPop, KPrompt, KRadio, KSegmentedControl): add types [KHCP-6971] Apr 17, 2023
@@ -264,12 +265,13 @@ export type DropdownFooterTextPosition = 'sticky' | 'static'
</script>

<script setup lang="ts">

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove empty line

Suggested change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment on lines 93 to 94
(e: 'change', value: string | boolean | number | object): void;
(e: 'update:modelValue', value: string | boolean | number | object): void;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: no semicolons needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed


export default {
inheritAttrs: false,
}
</script>

<script setup lang="ts">

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove empty line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

src/components/KPrompt/KPrompt.vue Show resolved Hide resolved
@@ -277,6 +277,7 @@ export default {
</script>

<script setup lang="ts">

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove empty line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

adamdehaven
adamdehaven previously approved these changes Apr 17, 2023
kaiarrowood
kaiarrowood previously approved these changes Apr 20, 2023
@DariaYeremina DariaYeremina merged commit 06079a2 into main Apr 20, 2023
@DariaYeremina DariaYeremina deleted the feat/khcp-6971 branch April 20, 2023 14:39
kongponents-bot pushed a commit that referenced this pull request Apr 20, 2023
# [8.53.0](v8.52.0...v8.53.0) (2023-04-20)

### Bug Fixes

* **KTable:** loosen types passed to slots in KTable ([#1299](#1299)) ([3c7a1bc](3c7a1bc))

### Features

* **KPop, KPrompt, KRadio, KSegmentedControl:** add types [KHCP-6971] ([#1292](#1292)) ([06079a2](06079a2))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 8.53.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants