Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kpop): camel case placement #1308

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Conversation

Leopoldthecoder
Copy link
Member

Summary

Problem

Kapture 2023-04-21 at 15 59 09

KPop with a two-word placement (e.g. topStart , rightEnd , etc.) has wrong position. This is observed in the shared-ui-components CI.

Cause

In src/components/KPop/KPop.vue, this.placement is a camel case string, but new Popper() expects the placement field to be a kebab case string. There used to be a map to do the case transformation, but it was removed in #1292.

Fix

Convert placement to kebab case before passing it to new Popper().

PR Checklist

  • Does not introduce dependencies
  • Functional: all changes do not break existing APIs and if so, bump major version.
  • Tests pass: check the output of yarn test
  • Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
  • Framework style: abides by the essential rules in Vue's style guide
  • Cleanliness: does not have formatting issues, unused code (e.g., console.logs, debugger), or leftover comments
  • Docs: includes a technically accurate README, uses JSDOC where appropriate

@Leopoldthecoder Leopoldthecoder requested a review from a team as a code owner April 21, 2023 08:11
@netlify
Copy link

netlify bot commented Apr 21, 2023

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 584f990
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/64424534d2330f00088d398a
😎 Deploy Preview https://deploy-preview-1308--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Leopoldthecoder Leopoldthecoder enabled auto-merge (squash) April 21, 2023 08:29
@Leopoldthecoder Leopoldthecoder merged commit 110ecd6 into main Apr 21, 2023
@Leopoldthecoder Leopoldthecoder deleted the fix/popover-placement branch April 21, 2023 11:34
kongponents-bot pushed a commit that referenced this pull request Apr 21, 2023
## [8.53.1](v8.53.0...v8.53.1) (2023-04-21)

### Bug Fixes

* **kpop:** camel case placement ([#1308](#1308)) ([110ecd6](110ecd6))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 8.53.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants