Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
KPop
with a two-wordplacement
(e.g.topStart
,rightEnd
, etc.) has wrong position. This is observed in theshared-ui-components
CI.Cause
In
src/components/KPop/KPop.vue
,this.placement
is a camel case string, butnew Popper()
expects theplacement
field to be a kebab case string. There used to be a map to do the case transformation, but it was removed in #1292.Fix
Convert
placement
to kebab case before passing it tonew Popper()
.PR Checklist