Skip to content

Commit

Permalink
address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
czeslavo committed May 25, 2023
1 parent e62926f commit 4aa6b29
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 11 deletions.
22 changes: 13 additions & 9 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,17 +77,21 @@ Adding a new version? You'll need three changes:
[#3832](https://github.com/Kong/kubernetes-ingress-controller/pull/3832)
- Added license agent for Konnect-managed instances.
[#3883](https://github.com/Kong/kubernetes-ingress-controller/pull/3883)
- `Service`, `Route`, and `Consumer` Kong entities now get assigned deterministic
IDs based on their unique properties (name, username, etc.) instead of random
UUIDs.
After the upgrade to 2.10.0, the controller will re-create all the existing
entities (Services, Routes, and Consumers) with the new IDs. That can
- `Service`, `Route`, and `Consumer` Kong entities now can get assigned
deterministic IDs based on their unique properties (name, username, etc.)
instead of random UUIDs. To enable this feature, set `FillIDs` feature gate
to `true`.
It's going to be useful in cases where stable IDs are needed across multiple
Kong Gateways managed by KIC (e.g. for the integration with Konnect and
reporting metrics that later can be aggregated across multiple instances based
on the entity's ID).
When `FillIDs` will be enabled, the controller will re-create all the existing
entities (Services, Routes, and Consumers) with the new IDs assigned. That can
potentially lead to temporary downtime between the deletion of the old entities
and the creation of the new ones.
Users might want to disable the feature if their existing DB-backed setup
consists of a huge amount of entities for which the recreation can take
significant time. It is possible to opt out of this behavior by setting
`FillIDs` feature gate to `false`.
Users should be cautious about enabling the feature if their existing DB-backed
setup consists of a huge amount of entities for which the recreation can take
significant time.
[#3933](https://github.com/Kong/kubernetes-ingress-controller/pull/3933)
[#4075](https://github.com/Kong/kubernetes-ingress-controller/pull/4075)
- Added translator to translate ingresses under `networking.k8s.io/v1` to
Expand Down
2 changes: 1 addition & 1 deletion FEATURE_GATES.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ Features that reach GA and over time become stable will be removed from this tab
| GatewayAlpha | `false` | Alpha | 2.6.0 | TBD |
| ExpressionRoutes | `false` | Alpha | 2.10.0 | TBD |
| CombinedServices | `false` | Alpha | 2.10.0 | TBD |
| FillIDs | `true` | Beta | 2.10.0 | 3.0.0 |
| FillIDs | `false` | Alpha | 2.10.0 | 3.0.0 |

**NOTE**: The `Gateway` feature gate refers to [Gateway
API](https://github.com/kubernetes-sigs/gateway-api) APIs which are in
Expand Down
1 change: 1 addition & 0 deletions internal/dataplane/parser/parser_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5208,6 +5208,7 @@ func TestParser_FillsEntitiesIDs(t *testing.T) {
})
require.NoError(t, err)
p := mustNewParser(t, s)
p.featureFlags.FillIDs = true

result := p.BuildKongConfig()
require.Empty(t, result.TranslationFailures)
Expand Down
2 changes: 1 addition & 1 deletion internal/manager/featuregates/feature_gates.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,6 @@ func GetFeatureGatesDefaults() map[string]bool {
CombinedRoutesFeature: true,
ExpressionRoutesFeature: false,
CombinedServicesFeature: false,
FillIDsFeature: true,
FillIDsFeature: false,
}
}

0 comments on commit 4aa6b29

Please sign in to comment.