Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support minimum TLS v1.2 for webhook admission server #1671

Merged
merged 2 commits into from
Aug 5, 2021

Conversation

shaneutt
Copy link
Contributor

@shaneutt shaneutt commented Aug 5, 2021

What this PR does / why we need it:

This is in direct response to the gosec lint which
we disabled due to backwards compatibility issues
in the v1.3.x releases of KIC, but now with KIC v2
on the horizon it's time to pull off the band-aid.

Which issue this PR fixes

Resolves #1065

PR Readiness Checklist:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

This is in direct response to the gosec lint which
we disabled due to backwards compatibility issues
in the v1.3.x releases of KIC, but now with KIC v2
on the horizon it's time to pull off the band-aid.
@shaneutt shaneutt added this to the Blockers for KIC 2.0 GA milestone Aug 5, 2021
@shaneutt shaneutt self-assigned this Aug 5, 2021
@shaneutt shaneutt requested a review from a team as a code owner August 5, 2021 21:48
@shaneutt shaneutt linked an issue Aug 5, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #1671 (38ff5bd) into next (b00580a) will decrease coverage by 0.47%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1671      +/-   ##
==========================================
- Coverage   46.23%   45.75%   -0.48%     
==========================================
  Files          70       70              
  Lines        6837     6838       +1     
==========================================
- Hits         3161     3129      -32     
- Misses       3304     3340      +36     
+ Partials      372      369       -3     
Flag Coverage Δ
integration-test 45.75% <100.00%> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/admission/server.go 30.76% <100.00%> (+0.41%) ⬆️
internal/sendconfig/sendconfig.go 41.48% <0.00%> (-12.60%) ⬇️
internal/ctrlutils/ingress-status.go 47.71% <0.00%> (-3.38%) ⬇️
internal/proxy/clientgo_cached_proxy_resolver.go 53.98% <0.00%> (-1.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b00580a...38ff5bd. Read the comment docs.

@shaneutt shaneutt enabled auto-merge (squash) August 5, 2021 22:04
@shaneutt shaneutt disabled auto-merge August 5, 2021 22:04
@shaneutt shaneutt enabled auto-merge (squash) August 5, 2021 22:05
@shaneutt shaneutt merged commit de9d902 into next Aug 5, 2021
@shaneutt shaneutt deleted the tls-v1.2-minimum-webhook-admission-server branch August 5, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop older TLS support in KIC
2 participants