Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress V1: wildcard should match only a single subdomain level #837

Closed
mflendrich opened this issue Sep 11, 2020 · 6 comments
Closed

Ingress V1: wildcard should match only a single subdomain level #837

mflendrich opened this issue Sep 11, 2020 · 6 comments
Labels
area/kong Issue with Kong proxy behavior, rather than the controller pending author feedback wontfix This will not be worked on

Comments

@mflendrich
Copy link
Contributor

Kubernetes 1.19 API and Ingress V1 KEP say the following about wildcard host matches:

The wildcard character '*' must appear by itself as the first DNS label and matches only a single label.

Specifically:

  • "*.foo.com" matches "bar.foo.com" because they share an the same suffix "foo.com".
  • "*.foo.com" does not match "aaa.bbb.foo.com" as the wildcard only matches a single label.
  • "*.foo.com" does not match "foo.com", as the wildcard must match a single label.

Today, if KIC gets an Ingress stating Host: *.foo.com, it will configure Kong to match multiple levels of subdomains (where it should match only one). In other words, Kong will match aaa.bbb.foo.com (from the example above) where it shouldn't.

@hbagdi
Copy link
Member

hbagdi commented Sep 11, 2020

This is not supported by Kong and hence blocked. Feature request in Kong: Kong/kong#6334.

@hbagdi hbagdi added the area/kong Issue with Kong proxy behavior, rather than the controller label Sep 11, 2020
@stale
Copy link

stale bot commented Mar 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Will be closed unless advocated for within 7 days label Mar 20, 2021
@stale stale bot closed this as completed Mar 27, 2021
@hbagdi hbagdi reopened this Mar 29, 2021
@stale stale bot removed the stale Will be closed unless advocated for within 7 days label Mar 29, 2021
@shaneutt
Copy link
Contributor

Looks like Kong/kong#6334 is resolved and we are unblocked, where are we at with this one?

@mflendrich
Copy link
Contributor Author

Kong/kong#6334 is closed as not fixed.
We rely on that resolution in order to bring this feature to KIC.

Community users: if you're interested in this feature, please bring this up in Kong/kong#7327

@mflendrich mflendrich added the wontfix This will not be worked on label Mar 23, 2022
@hbagdi
Copy link
Member

hbagdi commented Mar 23, 2022

I think this should be left open and we should work towards a resolution. I understand it hasn't happened in over a year but that doesn't mean we should label as 'wontfix'.
Most networking stacks expect * to match a single DNS label and we should make sure that we are not the exception in this case.

@shaneutt
Copy link
Contributor

It sounds like you're advocating that we get priority for this to put it on the roadmap for upcoming releases. @scseanchow please take a look and let's discuss the impact and whether this would fit into an upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kong Issue with Kong proxy behavior, rather than the controller pending author feedback wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants