-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingress V1: Parse Ingress V1 entries from Store. #832
Conversation
04a371a
to
bdf07d1
Compare
dd34d9c
to
4180a82
Compare
68d1782
to
3bb41da
Compare
bdb59f1
to
0a0a1cb
Compare
0a0a1cb
to
d1a3a2b
Compare
test(parser): testFromIngressV1() Copied verbatim from testFromIngressV1beta1()
d1a3a2b
to
285c7cb
Compare
0d55a6b
to
acaf329
Compare
Assumes that Kong prefers the longest match if multiple Prefix routes match.
acaf329
to
2ccafa8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on my work in #843, I think this is reasonably good to go. There are issues elsewhere (raised in #843), but not with these changes, more things alongside them that were in the controller before and whose limitations are now becoming apparent.
+1 on most of Harry's comments, but I believe they've now been addressed. I'll wait for his follow-up if he has any remaining items that we should continue to discuss here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not sure about route priorities. They come into effect only if there is a regex route (they don't have any effect for regular paths).
Let's revisit this later. For most users, this is intuitive enough that it should not cause problems. Famous last words.
closes #789
closes #791
This PR:
parser.Build()
withfromIngressV1()
: as of now, parser.Build includes v1 ingresses in the resulting KongState. There are three bits that we still need after this PR for full KEP compatibility:spec.ingressClass
fielda.foo.com
anda.b.foo.com
both match*.foo.com
, where the KEP expects only the former to match)After this PR, KIC practically supports Ingress V1 (in a scope specified above).
Also,
fromIngressV1
is unit-tested but there's no high level test forparser.Build
actually handling ingressv1 correctly. I'd like to spark a discussion about the right way to test this change (on a higher level than unit testing).Notes to reviewers: