Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug 132: Propagate hashoncookie and hashoncookiepath settings to … #139

Merged
merged 3 commits into from
Sep 27, 2018

Conversation

jdevalk2
Copy link
Contributor

Fixes bug report #132

@codecov-io
Copy link

codecov-io commented Sep 21, 2018

Codecov Report

Merging #139 into master will decrease coverage by 5.29%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #139     +/-   ##
=========================================
- Coverage   31.66%   26.37%   -5.3%     
=========================================
  Files          33       46     +13     
  Lines        2956     3591    +635     
=========================================
+ Hits          936      947     +11     
- Misses       1906     2530    +624     
  Partials      114      114
Impacted Files Coverage Δ
internal/ingress/controller/kong.go 1.14% <0%> (-0.01%) ⬇️
internal/apis/admin/credential.go 0% <0%> (ø)
internal/apis/admin/service.go 0% <0%> (ø)
internal/apis/admin/plugin.go 0% <0%> (ø)
internal/apis/admin/admin_wrapper.go 0% <0%> (ø)
internal/apis/admin/certificate.go 0% <0%> (ø)
internal/apis/admin/kong_client.go 11.11% <0%> (ø)
internal/apis/admin/api_helper.go 0% <0%> (ø)
internal/apis/admin/sni.go 0% <0%> (ø)
internal/apis/admin/consumer.go 0% <0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de9e38c...b0f9b6a. Read the comment docs.

@jdevalk2
Copy link
Contributor Author

jdevalk2 commented Sep 24, 2018

I am added to a group with a signed corporate CLA now. Is there a bot that checks CLA membership?

@hbagdi
Copy link
Member

hbagdi commented Sep 27, 2018

I am added to a group with a signed corporate CLA now. Is there a bot that checks CLA membership?

We don't check for CLAs as of this moment.

Thank you for contributing the fix!

@hbagdi hbagdi merged commit ab5b6c5 into Kong:master Sep 27, 2018
@jdevalk2 jdevalk2 deleted the feature/fixbug132 branch September 27, 2018 18:40
hbagdi pushed a commit that referenced this pull request Oct 23, 2018
…operties to Upstream object

These properties were introduced in Kong 0.14 and
were missed when Ingress Controller added support
for it.
This change allows configuring these
properties in Upstream in Kong using
KongIngress Custom Resource.

From #139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants