Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for path only based routing #142

Merged
merged 1 commit into from
Oct 2, 2018

Conversation

hbagdi
Copy link
Member

@hbagdi hbagdi commented Sep 26, 2018

Host is not a required field in Kubernetes Ingress Spec.
This is a small change which instantiates routes in Kong based on path
only.

Fix #84

Host is not a required field in Kubernetes Ingress Spec.
This is a small change which instantiates routes in Kong based on path
only.

Fix #84
@codecov-io
Copy link

Codecov Report

Merging #142 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   26.41%   26.39%   -0.03%     
==========================================
  Files          46       46              
  Lines        3585     3588       +3     
==========================================
  Hits          947      947              
- Misses       2524     2527       +3     
  Partials      114      114
Impacted Files Coverage Δ
internal/ingress/controller/kong.go 1.14% <0%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f3a244...c32593f. Read the comment docs.

@hbagdi hbagdi merged commit dc3a19b into master Oct 2, 2018
@hbagdi hbagdi deleted the feat/path-only-based-routing branch October 2, 2018 00:00
hbagdi added a commit that referenced this pull request Oct 23, 2018
Host is not a required field in Kubernetes Ingress Spec.
This is a small change which instantiates routes in Kong based on path
only.

Fix #84
From #142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants