Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport fix pluginDeepEqual when integer value is decoded as float64 for 0.1.x #196

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

fffonion
Copy link
Contributor

@fffonion fffonion commented Nov 9, 2018

cherry-picked from 1f7ad0d

@fffonion fffonion force-pushed the fix/backport-plugin-deep-equal branch from bb9aaad to 9bb2997 Compare November 9, 2018 00:12
@fffonion fffonion requested a review from hbagdi November 9, 2018 00:14
@codecov-io
Copy link

codecov-io commented Nov 9, 2018

Codecov Report

Merging #196 into 0.1.x will increase coverage by 0.56%.
The diff coverage is 85%.

Impacted file tree graph

@@            Coverage Diff            @@
##            0.1.x    #196      +/-   ##
=========================================
+ Coverage   26.34%   26.9%   +0.56%     
=========================================
  Files          47      47              
  Lines        3618    3654      +36     
=========================================
+ Hits          953     983      +30     
- Misses       2551    2554       +3     
- Partials      114     117       +3
Impacted Files Coverage Δ
internal/ingress/controller/kong.go 5.03% <85%> (+3.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37e7e60...9bb2997. Read the comment docs.

@fffonion fffonion changed the title fix pluginDeepEqual when integer value is decoded as float64 backport fix pluginDeepEqual when integer value is decoded as float64 for 0.1.x Nov 9, 2018
@hbagdi hbagdi merged commit fc359d0 into 0.1.x Nov 9, 2018
@hbagdi hbagdi deleted the fix/backport-plugin-deep-equal branch November 9, 2018 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants