fix(proxy) delay startup to allow cache population #2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Insert a 5-second delay in the proxy start function. This allows time for the controllers to populate the proxy cache before the first sync, as a temporary mitigation for #2249. Add unreleased 2.2.1 changelog entry. Add missing 2.2.0 changelog TOC entry.
rainest
force-pushed
the
fix/delay-sync
branch
from
e8bf62c
to
7fbeef9
Compare
shaneutt
suggested changes
Feb 10, 2022
rainest
commented
Feb 10, 2022
Co-authored-by: Shane Utt <[email protected]>
shaneutt
approved these changes
Feb 10, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Insert a 5-second delay in the proxy start function. This allows time
for the controllers to populate the proxy cache before the first sync,
as a temporary mitigation for #2249.
Special notes for your reviewer:
E2E (which has the leadership election behavior test) at https://github.com/Kong/kubernetes-ingress-controller/runs/5129347551?check_suite_focus=true
Remembered afterwards that E2E can't get controller/proxy logs yet, and wouldn't do debug anyway, so
secondary.txt is the secondary's controller logs showing it gain leadership and not delete stuff.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR