fix: --update-state=false cause panic #253
Closed
+137
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lijiaocn <[email protected]> (cherry picked from commit 8e7e4df6a9d1fedcd69ded6e0ded475f9d8217a7)
|
|
Signed-off-by: lijiaocn <[email protected]>
Codecov Report
@@ Coverage Diff @@
## next #253 +/- ##
=======================================
Coverage ? 18.89%
=======================================
Files ? 24
Lines ? 2509
Branches ? 0
=======================================
Hits ? 474
Misses ? 1989
Partials ? 46
Continue to review full report at Codecov.
|
|
@lijiaocn |
hbagdi
pushed a commit
that referenced
this pull request
Apr 12, 2019
Previously, if status need not be synced, then leader election would fail and ingress controller would fail to start. This commit separates the logic out in a hacky way. With DB-less, if status of Ingress resource is not to be updated, then we don't even need to run leader-election. In a future commit, leader election logic and sync logic can be completely separated out, unlike currently, when on shutdown the sync logic updates the configmap. Fix #232 From #253
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lijiaocn [email protected]
(cherry picked from commit 8e7e4df6a9d1fedcd69ded6e0ded475f9d8217a7)
What this PR does / why we need it:
Separate "Leader election" from statusSync (internal/ingress/status/status.go).
This imports an independent electoral mechanism and fix bug #232 at the same time.
Which issue this PR fixes *:
fixes #232
Special notes for your reviewer: