feat(#3097): create warning translation failure events for CA secrets #3125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ranslation-events
…ranslation-events
czeslavo
changed the title
32 tasks
pmalek
reviewed
Nov 3, 2022
pmalek
approved these changes
Nov 3, 2022
pmalek
reviewed
Nov 3, 2022
pmalek
approved these changes
Nov 3, 2022
pmalek
previously approved these changes
Nov 3, 2022
czeslavo
force-pushed
the
feat/create-warning-translation-events
branch
from
11bdd43
to
c5c1b55
Compare
|
@pmalek PTAL, I had to force push to trigger checks as they got stuck. |
pmalek
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It starts creating Kubernetes Events for all TranslationFailures detected during the translation phase. It will create one event per causing object. An integration test suite is also added in order to track all translation failure cases - that should make eventual future refactors safer (e.g. moving validation rules from the parser to the controllers).
Which issue this PR fixes:
Part of #3097.
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR