chore(deploy) align listens with upstream #3165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the listen configurations in the deploy manifests to use the same parameters as the upstream default kong.conf listens.
|
Re-drafting after some failures but they look unrelated. |
|
At the cost of many silly timeline events, ran the split E2E job instead of the (still not split) E2E targeted job, since this doesn't need any binary changes, only manifest changes. That went fine (https://github.com/Kong/kubernetes-ingress-controller/actions/runs/3463905254) so looks like the other failure was just an artifact of whatever problems we see when re-using the runners for all E2E tests. |
randmonkey
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update the listen configurations in the deploy manifests to use the same parameters as the upstream default kong.conf listens.
Which issue this PR fixes:
Removes discrepancies between configuration here and kong.conf defaults (https://github.com/Kong/kong/blob/ea485a8467259c2f7fee5959d757fee6a7318c99/kong.conf.default#L527 and https://github.com/Kong/kong/blob/ea485a8467259c2f7fee5959d757fee6a7318c99/kong.conf.default#L397).
With #2435 resolved by 3.0 (as far as we know--there's one report that it's still happening but not one that I can replicate) there's no reason to not use the same config as upstream anymore.
Special notes for your reviewer:
E2E test for the modified manifests: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/3448701987
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR