Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace * in name of kong routes #3312

Merged
merged 3 commits into from
Jan 3, 2023
Merged

fix: replace * in name of kong routes #3312

merged 3 commits into from
Jan 3, 2023

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Jan 3, 2023

What this PR does / why we need it:

replace * in hostname to _ in kong route names, because _ could not appear in hostnames, and * is not allowed in kong route names. * in hostnames will cause application of kong configuration fail if CombinedRoutes is turned on if not replaced.

Which issue this PR fixes:

fixes #3311

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner January 3, 2023 07:14
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 74.1% // Head: 74.0% // Decreases project coverage by -0.0% ⚠️

Coverage data is based on head (fa19eb5) compared to base (9977760).
Patch coverage: 100.0% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3312     +/-   ##
=======================================
- Coverage   74.1%   74.0%   -0.1%     
=======================================
  Files        111     111             
  Lines      13285   13290      +5     
=======================================
- Hits        9854    9847      -7     
- Misses      2808    2815      +7     
- Partials     623     628      +5     
Impacted Files Coverage Δ
internal/dataplane/parser/translators/ingress.go 92.4% <100.0%> (+0.2%) ⬆️
internal/dataplane/parser/translate_tlsroute.go 57.3% <0.0%> (-6.8%) ⬇️
...nternal/controllers/gateway/udproute_controller.go 73.6% <0.0%> (-2.8%) ⬇️
...ternal/controllers/gateway/httproute_controller.go 54.2% <0.0%> (-1.7%) ⬇️
internal/store/store.go 66.5% <0.0%> (-0.5%) ⬇️
internal/dataplane/parser/parser.go 91.3% <0.0%> (+0.8%) ⬆️
...nternal/controllers/gateway/tcproute_controller.go 75.6% <0.0%> (+2.6%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@randmonkey randmonkey added this to the KIC v2.9.0 milestone Jan 3, 2023
pmalek
pmalek previously approved these changes Jan 3, 2023
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, but overall 👍

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Patryk Małek <[email protected]>
@randmonkey randmonkey requested a review from pmalek January 3, 2023 09:03
@randmonkey randmonkey merged commit afd0b10 into main Jan 3, 2023
@randmonkey randmonkey deleted the fix/wildcard_host branch January 3, 2023 09:41
@pmalek pmalek added the fix label Mar 1, 2023
@randmonkey randmonkey mentioned this pull request May 25, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generating route fails for wildcard hosts due to invalid name
3 participants