-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace * in name of kong routes #3312
Conversation
Codecov ReportBase: 74.1% // Head: 74.0% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3312 +/- ##
=======================================
- Coverage 74.1% 74.0% -0.1%
=======================================
Files 111 111
Lines 13285 13290 +5
=======================================
- Hits 9854 9847 -7
- Misses 2808 2815 +7
- Partials 623 628 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit, but overall 👍
Co-authored-by: Patryk Małek <[email protected]>
What this PR does / why we need it:
replace
*
in hostname to_
in kong route names, because_
could not appear in hostnames, and*
is not allowed in kong route names.*
in hostnames will cause application of kong configuration fail ifCombinedRoutes
is turned on if not replaced.Which issue this PR fixes:
fixes #3311
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR