-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(konnect): add client configuration #3455
Conversation
7fd40e0
to
8e8c261
Compare
1516a2a
to
a8cae48
Compare
Codecov ReportBase: 73.8% // Head: 73.6% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3455 +/- ##
=======================================
- Coverage 73.8% 73.6% -0.3%
=======================================
Files 115 118 +3
Lines 13971 14067 +96
=======================================
+ Hits 10322 10356 +34
- Misses 2993 3051 +58
- Partials 656 660 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
a8cae48
to
7bd0740
Compare
7bd0740
to
1beda7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally good, only some small comments reamains.
Co-authored-by: Patryk Małek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 ( I already feel the pain resolving conflicts: #3421)
Just make sure to resolve all the conversations also from @randmonkey
Oh oh, sorry for the inconvenience. 🙁
✅ |
What this PR does / why we need it:
--konnect-sync-enabled
feature flag along with Konnect Admin API client-specific configuration)NewKongClientForKonnectRuntimeGroup
) that is to be used in the next PRsWhich issue this PR fixes:
Part of #3437.
Notes to reviewers:
Even though the PR adds Konnect Admin Admin API client implementation, it does not use it yet. Next PRs are going to bring more tests and integrate the Konnect client into the dataplane loop. It's to keep the size of the PRs reasonable.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR